Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the problem of not stopping a failed flush correctly #4187

Merged
merged 3 commits into from
Mar 7, 2022
Merged

fix the problem of not stopping a failed flush correctly #4187

merged 3 commits into from
Mar 7, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4185

Problem Summary: when the flush stoped, the process was not returned correctly and it mistakenly updated the delta index which make the delta index corrupted.
Introduced by #3943

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Mar 7, 2022
@lidezhu lidezhu requested a review from flowbehappy March 7, 2022 06:21
@lidezhu lidezhu changed the title fix the problem of not stopping an failed flush correctly fix the problem of not stopping a failed flush correctly Mar 7, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 7, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.cpp         202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                      202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16705      9452             43.42%    187278  95568        48.97%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lidezhu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.cpp         202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                      202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9458             43.40%    187259  95541        48.98%

full coverage report (for internal network access only)

@lidezhu lidezhu requested a review from JaySon-Huang March 7, 2022 10:06
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: be1c7e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.cpp         202                91    54.95%          16                 0   100.00%         164                41    75.00%          92                57    38.04%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                      202                91    54.95%          16                 0   100.00%         164                41    75.00%          92                57    38.04%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9459             43.40%    187258  95537        48.98%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 4d8a1be into pingcap:master Mar 7, 2022
@lidezhu lidezhu deleted the fix-flush-error branch March 7, 2022 11:14
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.cpp         202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                     202                82    59.41%          16                 0   100.00%         164                36    78.05%          92                54    41.30%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9458             43.40%    187258  95535        48.98%

full coverage report (for internal network access only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB::Exception: DeltaMerge return wrong result
5 participants
@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @flowbehappy